branding: Laptop 1X not Framwork 1X#325
Merged
JohnAZoidberg merged 2 commits intomainfrom Apr 23, 2026
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Updates product/platform naming across documentation and CLI user-facing text to use “Laptop 1X”/“Framework Laptop 1X” terminology now that the ecosystem includes non-laptop products (e.g., Desktop).
Changes:
- Renames platform references in docs (README, examples, support matrices) from “Framework 1X” to “Laptop 1X” / “Framework Laptop 1X”.
- Updates CLI help text and shell completion descriptions for several options to reflect the new naming.
- Refreshes internal Rust doc comments describing platforms / board IDs to match the updated branding.
Reviewed changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 10 comments.
Show a summary per file
| File | Description |
|---|---|
| support-matrices.md | Renames platform column headers and platform labels in the support/dependency matrices. |
| framework_tool/completions/zsh/_framework_tool | Updates zsh completion descriptions for FW16-only options. |
| framework_tool/completions/fish/framework_tool.fish | Updates fish completion descriptions for FW16-only options. |
| framework_lib/src/util.rs | Updates Platform enum doc comments to use “Framework Laptop …” naming. |
| framework_lib/src/commandline/mod.rs | Updates manual (UEFI) help text and comments to use “Laptop …” naming. |
| framework_lib/src/commandline/clap_std.rs | Updates clap-derived option doc comments for FW16-only options. |
| framework_lib/src/chromium_ec/mod.rs | Updates EC-related doc comment naming for Laptop 13 AMD AI 300. |
| framework_lib/src/chromium_ec/commands.rs | Updates BoardIdType doc comments to use “Laptop …” naming. |
| README.md | Updates the Port I/O / OS support table headings to “Framework Laptop …”. |
| EXAMPLES_ADVANCED.md | Updates example headings and section titles to “Framework Laptop …”. |
| EXAMPLES.md | Updates example headings/sections and embedded help output text to “Laptop …”. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Since we have more than laptops now. Signed-off-by: Daniel Schaefer <dhs@frame.work>
Signed-off-by: Daniel Schaefer <dhs@frame.work>
JohnAZoidberg
force-pushed
the
branding-laptop
branch
from
1b43443 to
4670908
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since we have more than laptops now.